Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to fix importlib.util issue #109

Closed
wants to merge 1 commit into from

Conversation

drewoldag
Copy link
Collaborator

No description provided.

@drewoldag drewoldag requested a review from maxwest-uw October 29, 2024 23:16
@drewoldag drewoldag self-assigned this Oct 29, 2024
@drewoldag drewoldag linked an issue Oct 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.15%. Comparing base (ea42b17) to head (45b9010).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   41.10%   41.15%   +0.05%     
==========================================
  Files          18       18              
  Lines        1017     1018       +1     
==========================================
+ Hits          418      419       +1     
  Misses        599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [ea42b17] <v0.1.2> After [53648c6] Ratio Benchmark (Parameter)
1.54±0.8s 2.59±1s ~1.68 benchmarks.time_computation
2.62k 3.46k 1.32 benchmarks.mem_list

Click here to view all benchmarks.

@maxwest-uw
Copy link

when I added the import line, it fixed the problem I was having (although my fibad scripts still aren't running ☹️ )

@drewoldag
Copy link
Collaborator Author

Going to close this PR since it's been sitting around for a while, and it's not clear that it's really the solution to the problem. I should be able to spend more time on KBMOD-related FIBAD work in the next week, so I can reopen this PR if needed.

@drewoldag drewoldag closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'importlib' has no attribute 'util'
2 participants